[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
Shoaib Meenai via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 23 08:27:38 PST 2016
smeenai added a comment.
In https://reviews.llvm.org/D26934#603997, @EricWF wrote:
> There are two usages of `_LIBCPP_DISABLE_DLL_IMPORT_EXPORT` in `CMakeLists.txt` and `__config_site.in` that need to be changed as well.
Oops, will fix.
> Also what about users of the existing name `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS`? Should we #error to inform them of the change or should we automatically translate it to the new name for them?
I'd prefer `#error`; that way we can eventually just drop the macro. Ideally there wouldn't be too many users to begin with, since it was only introduced two months ago, and it hasn't made its way to a release yet.
I'll upload a new diff with those changes later today.
More information about the cfe-commits