[PATCH] D27024: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 16:55:05 PST 2016


STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

[libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

Change "unsigned n = 0;" to "int n = 0;". It's being compared to int elements and ptrdiff_t distances.

test/std/containers/sequences/forwardlist/forwardlist.cons/move.pass.cpp
This one's a little special, but not really. "*i == n" is comparing MoveOnly to n.
MoveOnly is implicitly constructible from int, so int is the correct type to use here.


https://reviews.llvm.org/D27024

Files:
  test/std/containers/sequences/forwardlist/forwardlist.cons/copy.pass.cpp
  test/std/containers/sequences/forwardlist/forwardlist.cons/copy_alloc.pass.cpp
  test/std/containers/sequences/forwardlist/forwardlist.cons/init.pass.cpp
  test/std/containers/sequences/forwardlist/forwardlist.cons/init_alloc.pass.cpp
  test/std/containers/sequences/forwardlist/forwardlist.cons/move.pass.cpp
  test/std/containers/sequences/forwardlist/forwardlist.cons/range.pass.cpp
  test/std/containers/sequences/forwardlist/forwardlist.cons/range_alloc.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27024.78994.patch
Type: text/x-patch
Size: 8100 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161123/59912f90/attachment.bin>


More information about the cfe-commits mailing list