[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

Eric van Gyzen via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 12:11:33 PST 2016

vangyzen added inline comments.

Comment at: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:50
+        }
         std::locale l(LOCALE_en_US_UTF_8);
EricWF wrote:
> I think we should reset the global locale so it's different than the one we pass to `std::locale l(...)`. That way we're testing that we don't accidental use the global locale.
Good idea.


More information about the cfe-commits mailing list