[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 08:50:51 PST 2016

erichkeane added a comment.

I believe that this is a good patch that solves an open Bug.  See : https://llvm.org/bugs/show_bug.cgi?id=25965

I think the SPEC case is much less compelling, but I think that using a float explicitly in a conditional is something I really wouldn't expect a warning on.

@rsmith You had commented on the bug initially suggesting suppressing the diagnostic entirely in this case.  Do you still feel that way?


More information about the cfe-commits mailing list