[PATCH] D26657: [Sema] Respect DLL attributes more faithfully
Shoaib Meenai via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 21 17:40:15 PST 2016
smeenai added a comment.
General coding style question. Over here, I'm creating a local helper function. However, that helper needs to access member functions of Sema, which is why I made it a private member function right now, which also unfortunately makes the change somewhat non-local (since the header file needs to be modified as well). I can think of two alternatives:
- Define a local helper lambda (which will capture `this`) instead of a private member function.
- Define a local static helper function and pass the Sema instance as a parameter so that it can call member functions on it.
Would either of those be preferable to what I currently have? I'm pretty new when it comes to llvm/clang changes, so stylistic feedback is greatly appreciated.
More information about the cfe-commits