[PATCH] D26814: [libcxx] [test] Change ifstream constructor tests to handle read-only files.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 14:16:30 PST 2016


STL_MSFT added a comment.

My changes to the ofstream.cons tests preserve the test coverage (as they already contain the machinery to create writable files).

Would you like it if I removed the "if (fs) { stuff }" blocks from the ifstream.cons tests entirely, and changed the comments to say things along the lines of "for basic_ifstream(const char *, ios_base::openmode) tests, we need writable files, so see BLAH"?


https://reviews.llvm.org/D26814





More information about the cfe-commits mailing list