[PATCH] D26774: [CUDA] Driver changes to support CUDA compilation on MacOS.

[Justin Lebar via cfe-commits]

jlebar marked 2 inline comments as done.
jlebar added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+  // Intentionally omitted from the switch above: llvm::Triple::CUDA.  CUDA
+  // compiles always need two toolchains, the CUDA toolchain and the host
+  // toolchain.  So the only valid way to create a CUDA toolchain is via
+  // CreateOffloadingDeviceToolChains.
----------------
tra wrote:
> should there be an assert() or llvm_unreachable() to ensure that? Right now we'll happily return default toolchain.
Unfortunately no -- the way the code is structured now, we get the toolchain before we have a chance to raise an error.

I agree that's pretty broken...


================
Comment at: clang/test/Driver/cuda-detect.cu:67
 // RUN:     -check-prefix LIBDEVICE -check-prefix LIBDEVICE35
+// RUN: %clang -### -v --target=i386-unknown-linux --cuda-gpu-arch=sm_35 \
+// RUN:   -nocudainc --cuda-path=%S/Inputs/CUDA/usr/local/cuda %s 2>&1 \
----------------
tra wrote:
> Should that be --target=i386-apple-macosx ?
Wow, good eye.


https://reviews.llvm.org/D26774