[PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 16 18:07:49 PST 2016


rsmith added a comment.

This is causing warnings to fire for headers shared between C and C++, where the "give the enum an unsigned underlying type" advice doesn't work, and where the code in question will never be built for the MS ABI. It seems really hard to justify this being on by default.

I'm going to turn it off by default for now, but we should probably consider turning it back on by default when targeting the MS ABI (as a "your code is wrong" warning rather than a "your code is not portable" warning).


Repository:
  rL LLVM

https://reviews.llvm.org/D24289





More information about the cfe-commits mailing list