[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 16 16:03:38 PST 2016


rnk added inline comments.


================
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+    if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+         Old_TSK == TSK_ImplicitInstantiation) &&
         (TSK == TSK_ExplicitInstantiationDefinition ||
          DLLImportExplicitInstantiationDef)) {
----------------
Is this the right logic in the case of `Old_TSK == TSK_Implicit && TSK == TSK_Explicit`? We don't want a behavior change when DLLImport is not involved. A test for that case would be good.


https://reviews.llvm.org/D26657





More information about the cfe-commits mailing list