[PATCH] D26637: [change-namespace] handle constructor initializer: Derived : Base::Base() {} and added conflict detections

[Haojian Wu via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM once nits get fixed.



================
Comment at: change-namespace/ChangeNamespace.cpp:346
+                             hasDeclaration(DeclMatcher.bind("from_decl"))))),
+                         unless(hasAncestor(typeLoc(loc(qualType(hasDeclaration(
+                             decl(equalsBoundNode("from_decl")))))))))
----------------
hokein wrote:
> Maybe pull this `unless` matcher out and name it to make code more understandable.
Looks like you are missing this one.


================
Comment at: change-namespace/ChangeNamespace.cpp:543
+  auto Err = FileToReplacements[Deletion.getFilePath()].add(Deletion);
+  if (Err) {
+    llvm_unreachable(llvm::toString(std::move(Err)).c_str());
----------------
No `{}`.


https://reviews.llvm.org/D26637