[PATCH] D26582: [clang-tidy] Handle template instantiations in modenize-use-default check

[Aaron Ballman via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef<T>::~TempODef() = default;
+
----------------
malcolm.parsons wrote:
> aaron.ballman wrote:
> > Would it be better if the `= default` were on the inline declaration rather than the out-of-line definition? If so, that might be a reasonable FIXME to add to this test (assuming you don't feel like fixing it as part of this patch).
> > 
> > Also, does the `= delete` check suffer from the same issue?
> There are valid reasons for having out-of-line definitions, even when defaulted.
> The delete check only triggers if there is no definition. Template instantiation can't copy a definition that doesn't exist.
Hmm, I suppose that is true. Thanks!


https://reviews.llvm.org/D26582