[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 10:22:24 PST 2016


EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include <cmath>
----------------
Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc`


================
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:22
+
+#ifndef _LIBCPP_VERSION
+#error _LIBCPP_VERSION not defined
----------------
You don't need this `_LIBCPP_VERSION` check here.


https://reviews.llvm.org/D25403





More information about the cfe-commits mailing list