[PATCH] D24235: [OpenCL] Improve double literal handling

Sven van Haastregt via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 03:19:43 PST 2016


svenvh added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:3732
 
   // If this is an implicit conversion from float -> double, remove it.
   if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
----------------

The comment should mention float -> float now as well.


================
Comment at: lib/Sema/SemaExpr.cpp:712
+  Res = ImplicitCastExpr::Create(Context, T, CK_LValueToRValue, E,
+                                   nullptr, VK_RValue);
 
----------------

You can change this back to what it was before your first commit (which also fixes the indentation).


https://reviews.llvm.org/D24235





More information about the cfe-commits mailing list