[PATCH] D26637: [change-namespace] handle constructor initializer: Derived : Base::Base() {} and added conflict detections

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 06:08:42 PST 2016


hokein added inline comments.


================
Comment at: change-namespace/ChangeNamespace.cpp:343
+  // FIXME(ioeric): this will change a base-class constructor initializer from
+  // "Base::Base(...)" to "ns::Base()", which compiles but is not perfect.
   Finder->addMatcher(nestedNameSpecifierLoc(
----------------
Maybe we can filter it out in `run(MatcherResult)` function rather than in AST matcher? If we meet a specifier like `Base::Base()` in `CXXCtorInitializer`, we just skip them.


https://reviews.llvm.org/D26637





More information about the cfe-commits mailing list