[PATCH] D26509: [OpenCL] Fix integer parameters of enqueue_kernel

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 11 12:16:34 PST 2016


yaxunl added a comment.

I thought the number of events was also changed to size_t type. Now I understand. Probably I was misled by the summary:

"Parameters representing number of events as well as sizes of enqueued block arguments in enqueue_kernel function are specified as uint type. This prevents passing sizeof(int) type expressions on the 64 bit architectures because they return size_t which is a 64 bit wide in contrast to uint that is always 32 bits."

It sounds like number of events should also be changed. Maybe drop 'number of events as well as' from the above sentence?


https://reviews.llvm.org/D26509





More information about the cfe-commits mailing list