[PATCH] D26139: Tests for strings conversions under libcpp-no-exceptions

[Roger Ferrer Ibanez via cfe-commits]

rogfer01 added a comment.

I'd rather not to go the way of `TEST_TRY` and `TEST_CASE` macros.

As suggested by @rmaprath, I've been playing with grouping the tests in three categories: no exceptions (at all), should not throw, must throw. No changes are required for the first group. The third group is easy to protect with just a couple of ifdef / endif. The second group is the noisiest as we still want to run the code inside the try but we need to skip the try keyword and the catch handlers. This approach may be a bit cleaner.

Any further suggestion? I plan to update the patch with the strategy above if no objections arise.


https://reviews.llvm.org/D26139