[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 11 07:15:42 PST 2016


aaron.ballman added a comment.

In https://reviews.llvm.org/D26511#592670, @malcolm.parsons wrote:

> In https://reviews.llvm.org/D26511#592665, @Prazek wrote:
>
> > It is introduced because of "modernize-use-delete" was too ambiguous because of operator delete, so it was changed to "modernize-use-equals-delete". But this case is not ambiguous at all, so I don't see point changing that.
>
>
> default can also be used in a switch.


Also, "default" has meaning in English, so it's plausible to read this as a check that modernizes your code to "use the default" for whatever the user might be thinking of when they enable the check, so I think there is existing ambiguity with the current name.


https://reviews.llvm.org/D26511





More information about the cfe-commits mailing list