[PATCH] D26415: [XRay] Support AArch64 in Clang

Serge Rogatch via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 11 05:58:37 PST 2016


rSerge marked an inline comment as done.
rSerge added inline comments.


================
Comment at: lib/Driver/Tools.cpp:4903-4906
+    if (Triple.getOS() != llvm::Triple::Linux)
+      D.Diag(diag::err_drv_clang_unsupported)
+          << (std::string(XRayInstrumentOption) + " on non-Linux target OS.");
+    switch (Triple.getArch()) {
----------------
dberris wrote:
> Did you need to put an `else` before the switch? I don't know what happens when you're on Windows non-supported platform -- will this cause two diagnostics to be printed?
I thought that the statement after `D.Diag(diag::err_drv_clang_unsupported)` will not be executed. Let me check...


https://reviews.llvm.org/D26415





More information about the cfe-commits mailing list