[PATCH] D26410: [CodeGen] Don't emit the same global block multiple times.

John McCall via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 10 22:36:57 PST 2016


rjmccall added a comment.

This looks great.  One minor tweak and then it's ready.



================
Comment at: lib/CodeGen/CGBlocks.cpp:1057
+void CodeGenModule::putAddrOfGlobalBlock(const BlockExpr *BE,
+                                         llvm::Constant *Addr) {
+  bool Ok = EmittedGlobalBlocks.insert(std::make_pair(BE, Addr)).second;
----------------
We conventionally name these things "set" rather than "put".


https://reviews.llvm.org/D26410





More information about the cfe-commits mailing list