[PATCH] D26461: Tread TSan LLVM flags to driver: add TSan controlling flags to clang.

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 13:49:10 PST 2016

eugenis added inline comments.

Comment at: lib/Frontend/CompilerInvocation.cpp:735
+                   OPT_fno_sanitize_thread_data_races,
+                   Opts.SanitizeThreadDataRaces);
+  Opts.SanitizeThreadStackTraces =
alekseyshl wrote:
> eugenis wrote:
> > It seems common to hardcode the default option value here.
> > The same in SanitizerArgs.cpp.
> True, but the default value for these flags is already mentioned in more than one place, why not to try to reduce the complexity?
I guess I don't mind either way.


More information about the cfe-commits mailing list