[PATCH] D26454: Implement no_sanitize_address for global vars

Douglas Katzman via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 08:44:21 PST 2016


dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.

This was already submitted as r284272.

Regarding the use of Attr as a local variable name, I would prefer to remain consistent with the existing code in CodeGenFunction.cpp which was not touched by this patch.

line 720:  for (auto Attr : D->specific_attrs<NoSanitizeAttr>())

but I'm certainly not opposed to changing both places.


https://reviews.llvm.org/D26454

Files:
  include/clang/Basic/Attr.td
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Sema/AttributeList.h
  lib/CodeGen/SanitizerMetadata.cpp
  lib/Sema/SemaDeclAttr.cpp
  test/CodeGen/asan-globals.cpp
  test/SemaCXX/attr-no-sanitize-address.cpp
  test/SemaCXX/attr-no-sanitize.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26454.77357.patch
Type: text/x-patch
Size: 9482 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161109/a8bef164/attachment.bin>


More information about the cfe-commits mailing list