[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

Stephen Hines via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 12:26:41 PST 2016


srhines added a comment.

In https://reviews.llvm.org/D26385#589589, @eugenis wrote:

> This is a good change, but I don't think it is the right fix for PR30940. Instead of handling this in the NDK, we should change *::getIRStackGuard to fallback to __stack_chk_guard when targeting an old version.


Right, this is only addressing part of the problem related to that issue. I can probably put together a follow up to address the rest of the bug, although I am not all that familiar with __stack_chk_guard, so testing might be a problem.


https://reviews.llvm.org/D26385





More information about the cfe-commits mailing list