[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

Malcolm Parsons via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 02:20:44 PST 2016


malcolm.parsons added a comment.

In https://reviews.llvm.org/D25659#588663, @alexfh wrote:

> In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
>
> > I think, silently choosing one of the checks may be confusing and counter-intuitive. Should we just warn in case we see the same check enabled by multiple aliases?
>
>
> And by "aliases" I mean different names under which the check is registered. I'm not sure I see the benefit of introducing a separate concept and a separate API for registering checks under multiple names. This introduces another sort of dynamic binding, which we have to have good reasons for.


Is using `typeid()` on the constructed checks OK?


https://reviews.llvm.org/D25659





More information about the cfe-commits mailing list