[PATCH] D26203: [ClangTidy - performance-unnecessary-value-param]: Do not issue fix for functions that are referenced outside of callExpr

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 7 13:48:29 PST 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from a commenting nit, LGTM.



================
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:130
+  // Do not propose fixes when:
+  // 1. in macros since we cannot place them correctly
+  // 2. the function is virtual as it might break overrides
----------------
Not grammatically correct; should be "1. when the ParmVarDecl is in a macro, since..."


Repository:
  rL LLVM

https://reviews.llvm.org/D26203





More information about the cfe-commits mailing list