[PATCH] D26139: Tests for strings conversions under libcpp-no-exceptions

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 6 01:43:50 PST 2016

rmaprath added a comment.

In https://reviews.llvm.org/D26139#587587, @mclow.lists wrote:

> >   I think it might be better to add TEST_TRY and TEST_CATCH(...) macros defined like
> @rogfer01 said at the top that he didn't want to add "a magical TEST_TRY macro" - and I agree.  Someone tried that in another review, and I nixed it there.

I had a proposal for something along those lines in https://reviews.llvm.org/D14653, however those TEST_TRY and TEST_CATCH macros were trying to be "too smart".

I agree, having macros for `try` and `catch` sounds to me like it would set the wrong precedent.


More information about the cfe-commits mailing list