[PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 5 19:48:21 PDT 2016

djasper added a comment.

In case you still want to move forward with this, some more comments.

Why have you opted for doing this in getNewLineColumn instead of the UnwrappedLineFormatter::formatFirstToken() function I suggested? I think the latter would be way easier, but there might be cases I am not thinking of right now.

Comment at: docs/ClangFormatStyleOptions.rst:260
+  * ``BS_Whitesmiths`` (in configuration: ``Whitesmiths``)
+    Like ``Allman``, with the braces intended too.
   * ``BS_GNU`` (in configuration: ``GNU``)

Comment at: lib/Format/ContinuationIndenter.h:270
+  bool BlockNoExtraIndent;
   bool operator<(const ParenState &Other) const {
No. I don't think it is necessary to add an extra value to the indent state for this and doing so would be costly in runtime.


More information about the cfe-commits mailing list