[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 5 11:21:15 PDT 2016

klimek added a comment.

In https://reviews.llvm.org/D26288#586932, @ioeric wrote:

> - Addressed comments: handle non-existing files.

We're not really handling them now though? We're just printing an error?

My point is that we might run the replacement generation on a distributed system, and then group/deduplicate/apply them somewhere where the files might not actually exist (think the reduce stage of a mapreduce). If possible, I'd like to not rely on the existence of the file when we deal with Replacements. I'd find it especially problematic if the existence or non-existence of files changes the semantics of those operations.


More information about the cfe-commits mailing list