[PATCH] D26306: [AVX-512] Make VBMI instruction set enabling imply that the BWI instruction set is also enabled.
Craig Topper via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 4 20:52:15 PDT 2016
craig.topper added inline comments.
Comment at: test/Preprocessor/x86_target_features.c:212
+// RUN: %clang -target i386-unknown-unknown -march=atom -mavx512vbmi -mno-avx512vbmi -x c -E -dM -o - %s | FileCheck -match-full-lines --check-prefix=AVX512VBMINOAVX512BW %s
> Test is turning on and then off the same feature. Did you mean -mavx512bw -mno-avx512vbmi ?
> If the latter, I would prefer the compiler shout at me for providing contradicting flags than let the last flag win. Consider enforcing this in handleTargetFeatures().
It was supposed to be -mavx512vbmi -mno-avx512bw to verify that turning off bwi would turn off vbmi. The lack of warning is consistent with the behavior of all the other linked feature flags.
More information about the cfe-commits