[PATCH] D26302: [OpenCL] Remove redundant test for OpenCL header file

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 4 11:28:17 PDT 2016

Anastasia added inline comments.

Comment at: test/Headers/opencl-c-header.cl:48
-// ===
-// Compile for OpenCL 1.0 for the first time. A module should be generated.
-// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fdisable-module-hash -ftime-report %s 2>&1 | FileCheck --check-prefix=CHECK --check-prefix=CHECK-MOD %s
Considering that the above change removes around 30 parse times of CL header already, would it makes sense to keep this bit checking the modules for different versions are regenerated while for the same version are kept? This adds only 2 extra parsing of the header as I can see.

Are we sure such bits are covered by testing elsewhere?


More information about the cfe-commits mailing list