[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 3 14:38:49 PDT 2016

rsmith added a comment.

In https://reviews.llvm.org/D25311#576382, @bkramer wrote:

> I think clang already depends on libclangRewrite. libclangToolingCore is tiny, it's basically just the Replacement class and a couple of utilities. While it would be possible to hoist just the include handling and its dependencies out of libclangFormat into a separate library I'm not convinced that it's worth it. libclangFormat is tiny, the .a file is less than a megabyte and the impact on the clang binary is 400kB in a Release+Asserts build, a 0.5% increase.

Nonetheless, from a layering perspective, it doesn't make much sense for libSema to depend on libFormat. The functionality in question sounds like it belongs in Lex.


More information about the cfe-commits mailing list