[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

Alex Lorenz via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 2 10:48:22 PDT 2016

arphaman added a comment.

In https://reviews.llvm.org/D25811#586053, @kparzysz wrote:

> In https://reviews.llvm.org/D25811#586000, @arphaman wrote:
> > I've tested this patch on OS X and these 4 tests that you've changed now fail.
> >
> > The `XFAIL: with_system_cxx_lib` lines don't have any effect on my system - these tests get invoked as expected by lit. Let me know if there's anything else I can do to help you.
> That's surprising.  Seems like something is different on OS X.
>  Could you try compiling/running this small program?
>   #include <locale>
>   #include <iostream>
>   int main() {
>     std::locale x("en_US.UTF-8");
>     std::cout << x.name() << std::endl;
>   }
> If it prints "en_US.UTF-8", then I'm out of ideas... :)

Just tried it, I get "en_US.UTF-8"



More information about the cfe-commits mailing list