[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

Malcolm Parsons via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 1 13:35:58 PDT 2016

malcolm.parsons added a comment.

In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote:

> (1) I think that the aliases and the originals should be listed with -list-checks, because these are names under which the checks may be run (and sometimes the name may even imply different semantics for the check).

I've always found it odd that -list-checks only lists the enabled checks.
I think a list of enabled checks shouldn't report aliases that will not be used.

> (2) I'm not as certain about -dump-config, since I am not really familiar with that option, but I think we want to list the alias and the original under that as well because different check names may have different configuration options.

It was because of -dump-config that I noticed the checks were running twice.
I had to configure a check in two places to be sure it was configured how I wanted.
I don't think there is a use case for running the same check with different options at the same time.
Dumping options that won't be used isn't good either.

I'd like to remove cert-oop11-cpp's UseCERTSemantics option - see my comment on https://reviews.llvm.org/D12839.

An alternative to clang-tidy preferring the original check would be to complain if both are enabled.


More information about the cfe-commits mailing list