[PATCH] D26195: Ignore incomplete types when determining whether they are expensive to copy
Felix Berger via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 1 11:09:11 PDT 2016
flx added a comment.
In https://reviews.llvm.org/D26195#584730, @aaron.ballman wrote:
> In https://reviews.llvm.org/D26195#584724, @flx wrote:
> > In https://reviews.llvm.org/D26195#584712, @aaron.ballman wrote:
> > > Please add a test case with an incomplete type that would exercise this code path, otherwise, LGTM.
> > Hi Aaron,
> > do you have any advise on how to add an incomplete type? When debugging this I had a compilation unit that failed to compile causing it, but I'm not sure this is a good way to add a test case.
> A type like `class C;` is an incomplete type, as is `void`, so perhaps you can find a check that would let such a construct call through to `isExpensiveToCopy()`.
Great, this works and I was able to see the check produce a false positive without the proposed change here, but the test code introduces a compile error now due to the incomplete type used in the function definition. Is there a way to suppress that?
More information about the cfe-commits