[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

Aditya Kumar via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 15:37:08 PDT 2016

hiraditya added a comment.

In https://reviews.llvm.org/D25624#583167, @mehdi_amini wrote:

> I talked with Eric on IRC, he mentioned some benchmarks were ran. I'd like to understand what was the baseline?
>  Here we add *both* the inline keyword and the always_inline attribute. I'd like to know if there is a benchmarks that shows that always_inline is beneficial on top of the inline keyword. 
>  If we need to add always_inline anywhere: this is likely an inliner heuristic failure and we should at minima track it as an example to improve it.

I remmber that the constructor of std::string wouldn't inline without always_inline attribute https://reviews.llvm.org/D22782


More information about the cfe-commits mailing list