[PATCH] D26145: DebugInfo: support for DW_TAG_atomic_type

Adrian Prantl via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 11:07:11 PDT 2016


aprantl added a comment.

One more inline comment.



================
Comment at: test/CodeGen/debug-info-atomic.c:4
+// CHECK: !DIGlobalVariable(name: "i"{{.*}}type: !5, isLocal: false, isDefinition: true)
+// CHECK: !5 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !6)
+// CHECK: !6 = !DIDerivedType(tag: DW_TAG_atomic_type, baseType: !7)
----------------
Please use FileCheck variables ![[TYPE:[0-9]+]] instead of hardcoding the numbers. This is bound to break soon otherwise.


https://reviews.llvm.org/D26145





More information about the cfe-commits mailing list