[PATCH] D26032: [ASTMatcher] Add CXXNewExpr support to hasDeclaration

Ɓukasz Anforowicz via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 09:54:13 PDT 2016


lukasza added a comment.

FWIW, a non-owner LGTM:

- CXXNewExpr seems very similar to CallExpr, so it makes sense that hasDeclaration would behave similarily for both of these expressions (i.e. matching the "callee")
- The issues we've been trying to work through in https://reviews.llvm.org/D24361 mainly revolve around Type and QualType, so I think those issues should not apply to CXXNewExpr matching.


https://reviews.llvm.org/D26032





More information about the cfe-commits mailing list