[libcxx] r285538 - Add 'inline' but not 'always_inline' to std::strings destructor.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 30 20:42:50 PDT 2016


Author: ericwf
Date: Sun Oct 30 22:42:50 2016
New Revision: 285538

URL: http://llvm.org/viewvc/llvm-project?rev=285538&view=rev
Log:
Add 'inline' but not 'always_inline' to std::strings destructor.

Adding both 'inline' and 'always_inline' to the destructor has been contentious.
However most of the performance benefits can be gained by only adding 'inline',
and there is no reason to hold up that change while discussing the other.

Modified:
    libcxx/trunk/include/string

Modified: libcxx/trunk/include/string
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=285538&r1=285537&r2=285538&view=diff
==============================================================================
--- libcxx/trunk/include/string (original)
+++ libcxx/trunk/include/string Sun Oct 30 22:42:50 2016
@@ -806,7 +806,7 @@ public:
     basic_string(initializer_list<value_type> __il, const allocator_type& __a);
 #endif  // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS
 
-    ~basic_string();
+    inline ~basic_string();
 
     _LIBCPP_INLINE_VISIBILITY
     operator __self_view() const _NOEXCEPT { return __self_view(data(), size()); }




More information about the cfe-commits mailing list