[PATCH] D26057: [coroutines] Add CoawaitDependentExpr AST node and use it to properly build await_transform.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 19:13:05 PDT 2016


EricWF added inline comments.


================
Comment at: lib/AST/ExprClassification.cpp:191
   case Expr::DesignatedInitUpdateExprClass:
+  // FIXME How should we classify co_await expressions while they're still
+  // dependent?
----------------
@rsmith: What's the correct way to classify this type?


================
Comment at: lib/Sema/SemaCoroutine.cpp:33
 /// function type.
 static QualType lookupPromiseType(Sema &S, const FunctionProtoType *FnType,
+                                  SourceLocation KwLoc,
----------------
The changes to this function are all unrelated cleanup/improvements.


https://reviews.llvm.org/D26057





More information about the cfe-commits mailing list