[PATCH] D25204: Register Calling Convention, Clang changes

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 15:05:51 PDT 2016


erichkeane added a comment.

In https://reviews.llvm.org/D25204#581469, @rnk wrote:

> Remember the fight over _Atomic with MSVC's STL? The fallacy of the implementer's namespace is that there is only one implementer.
>  https://llvm.org/bugs/show_bug.cgi?id=19043
>
> We should prefer adding `__attribute__`s and `__declspec`s instead of keywords when possible.


In general, I can see the benefit of this rule, however in the case of calling conventions, I would think that keeping them all orthogonal is important.  Having "most" calling conventions work one way, and a couple a different way seems like a bigger problem.


https://reviews.llvm.org/D25204





More information about the cfe-commits mailing list