[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

Chandler Carruth via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 14:46:19 PDT 2016


chandlerc added a comment.

In https://reviews.llvm.org/D23752#581436, @mgorny wrote:

> This really doesn't solve the problems we have. We don't want to build and install two almost-identical copies of compiler-rt and clang headers, when we can just build one and make clang use it.


However, as I said before, I don't really think that this approach makes sense. I don't think we should be building Clang to re-use parts of some other Clang installation. I understand that is exactly what you want to do, but I disagree that it is a good idea. I think it is brittle and failure prone. I suggested ways you could make it work for your use cases however, but I don't think changing the CMake in this way is valid.


https://reviews.llvm.org/D23752





More information about the cfe-commits mailing list