[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

Chris Bieneman via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 13:41:46 PDT 2016


beanz added a comment.

This looks like it is in the direction I would expect. Please let me know once the final patch is ready.



================
Comment at: lib/Driver/Tools.cpp:2021
   std::string Plugin =
-      ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so";
+      ToolChain.getDriver().Dir + "/../lib" LLVM_RUNTIMES_LIBDIR_SUFFIX "/LLVMgold.so";
   CmdArgs.push_back(Args.MakeArgString(Plugin));
----------------
mgorny wrote:
> Note: I don't know if it's better to use LLVM_RUNTIMES_LIBDIR_SUFFIX here, or just #define LLVM_LIBDIR_SUFFIX in addition to that.
This should be `LLVM_LIBDIR_SUFFIX` as per Chandler's comments.


https://reviews.llvm.org/D23752





More information about the cfe-commits mailing list