[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 09:24:38 PDT 2016


thakis added a comment.

Thanks! Landing…



================
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+  // These already err, don't also warn.
+  !x &= 1; // expected-error{{expression is not assignable}}
+  !x |= 1; // expected-error{{expression is not assignable}}
----------------
hans wrote:
> And this is the reason you had to put a "not" on the second run line, right?
Right.


https://reviews.llvm.org/D26035





More information about the cfe-commits mailing list