[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 08:56:26 PDT 2016


thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.

This is a misspelling of the intended `!(x & A)` negated bit test that happens in practice every now and then.

I ran this on Chromium and all its dependencies, and it fired 0 times -- no false or true positives, but it would've caught a bug in an in-progress change that had to be caught by a Visual Studio warning instead.


https://reviews.llvm.org/D26035

Files:
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Sema/Sema.h
  lib/Sema/SemaExpr.cpp
  test/SemaCXX/warn-logical-not-compare.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26035.76049.patch
Type: text/x-patch
Size: 7910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161027/d03ff486/attachment-0001.bin>


More information about the cfe-commits mailing list