[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

A few late comments (seems to be relevant to the revision finally committed after all fixes).



================
Comment at: clang-tidy/utils/NamespaceAliaser.cpp:35
+    return None;
+
+
----------------
nit: Too many empty lines.


================
Comment at: clang-tidy/utils/NamespaceAliaser.cpp:41
+
+  // TODO(bangert): Doesn't consider the order of declarations.
+  // If we accidentially pick an alias defined later in the function,
----------------
Please use FIXME instead of TODO(...).


================
Comment at: clang-tidy/utils/NamespaceAliaser.h:35
+              llvm::StringRef Namespace,
+              const std::vector<std::string> &Abbreviations);
+
----------------
Use llvm::ArrayRef instead.


https://reviews.llvm.org/D24997