[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 14:26:22 PDT 2016


mgorny added inline comments.


================
Comment at: lib/Driver/ToolChains.cpp:3942
+      int Version;
+      if (SplitLine.first.trim() != "VERSION")
+        continue;
----------------
bruno wrote:
> You can check `Line.trim() != VERSION` before the `split` as to do not try to split unnecessary lines.
You mean `line.trim().startswith()`, correct?


https://reviews.llvm.org/D24954





More information about the cfe-commits mailing list