[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

[Justin Lebar via cfe-commits]

jlebar added a comment.

Thank you very much for the review!



================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+      auto &Members = ClassWithSpecialMembers[ID];
+      if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+    }
----------------
bkramer wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > Please drop the `push_back()` onto its own line.
> > This was actually how clang-tidy formatted the line.  My understanding is that we go with that in llvm projects?  Unless you're saying I have an outdated clang-tidy, in which case I will investigate that.
> It's what happens when your clang-format is using Google style. Some versions of clang-format ship with weird defaults, so you have to add -style=LLVM manually.
Er, s/clang-tidy/clang-format/


Repository:
  rL LLVM

https://reviews.llvm.org/D25647