[PATCH] D25851: [libcxx] [test] Fix unreferenced formal parameter warnings.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 17:18:27 PDT 2016


STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

Fix unreferenced formal parameter warnings. Found by MSVC as usual.


https://reviews.llvm.org/D25851

Files:
  test/std/utilities/optional/optional.object/optional.object.ctor/in_place_t.pass.cpp
  test/std/utilities/optional/optional.object/optional.object.swap/swap.pass.cpp
  test/std/utilities/optional/optional.specalg/swap.pass.cpp
  test/support/archetypes.hpp


Index: test/support/archetypes.hpp
===================================================================
--- test/support/archetypes.hpp
+++ test/support/archetypes.hpp
@@ -60,11 +60,11 @@
         ++alive; ++constructed; ++value_constructed;
     }
     template <bool Dummy = true, typename std::enable_if<Dummy && Explicit, bool>::type = true>
-    explicit TestBase(int x, int y) noexcept : value(y) {
+    explicit TestBase(int, int y) noexcept : value(y) {
         ++alive; ++constructed; ++value_constructed;
     }
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
-    TestBase(int x, int y) noexcept : value(y) {
+    TestBase(int, int y) noexcept : value(y) {
         ++alive; ++constructed; ++value_constructed;
     }
     template <bool Dummy = true, typename std::enable_if<Dummy && Explicit, bool>::type = true>
@@ -131,9 +131,9 @@
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
     constexpr ValueBase(int x) : value(x) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && Explicit, bool>::type = true>
-    explicit constexpr ValueBase(int x, int y) : value(y) {}
+    explicit constexpr ValueBase(int, int y) : value(y) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
-    constexpr ValueBase(int x, int y) : value(y) {}
+    constexpr ValueBase(int, int y) : value(y) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && Explicit, bool>::type = true>
     explicit constexpr ValueBase(std::initializer_list<int>& il, int y = 0) : value(il.size()) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
@@ -189,9 +189,9 @@
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
     constexpr TrivialValueBase(int x) : value(x) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && Explicit, bool>::type = true>
-    explicit constexpr TrivialValueBase(int x, int y) : value(y) {}
+    explicit constexpr TrivialValueBase(int, int y) : value(y) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
-    constexpr TrivialValueBase(int x, int y) : value(y) {}
+    constexpr TrivialValueBase(int, int y) : value(y) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && Explicit, bool>::type = true>
     explicit constexpr TrivialValueBase(std::initializer_list<int>& il, int y = 0) : value(il.size()) {}
     template <bool Dummy = true, typename std::enable_if<Dummy && !Explicit, bool>::type = true>
Index: test/std/utilities/optional/optional.specalg/swap.pass.cpp
===================================================================
--- test/std/utilities/optional/optional.specalg/swap.pass.cpp
+++ test/std/utilities/optional/optional.specalg/swap.pass.cpp
@@ -60,7 +60,7 @@
     Z(Z&&) { TEST_THROW(7);}
 
     friend constexpr bool operator==(const Z& x, const Z& y) {return x.i_ == y.i_;}
-    friend void swap(Z& x, Z& y) { TEST_THROW(6);}
+    friend void swap(Z&, Z&) { TEST_THROW(6);}
 };
 
 
Index: test/std/utilities/optional/optional.object/optional.object.swap/swap.pass.cpp
===================================================================
--- test/std/utilities/optional/optional.object/optional.object.swap/swap.pass.cpp
+++ test/std/utilities/optional/optional.object/optional.object.swap/swap.pass.cpp
@@ -61,7 +61,7 @@
     Z(Z&&) {TEST_THROW(7);}
 
     friend constexpr bool operator==(const Z& x, const Z& y) {return x.i_ == y.i_;}
-    friend void swap(Z& x, Z& y) {TEST_THROW(6);}
+    friend void swap(Z&, Z&) {TEST_THROW(6);}
 };
 
 
Index: test/std/utilities/optional/optional.object/optional.object.ctor/in_place_t.pass.cpp
===================================================================
--- test/std/utilities/optional/optional.object/optional.object.ctor/in_place_t.pass.cpp
+++ test/std/utilities/optional/optional.object/optional.object.ctor/in_place_t.pass.cpp
@@ -55,7 +55,7 @@
 class Z
 {
 public:
-    Z(int i) {TEST_THROW(6);}
+    Z(int) {TEST_THROW(6);}
 };
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25851.75371.patch
Type: text/x-patch
Size: 4184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161021/fd57736a/attachment-0001.bin>


More information about the cfe-commits mailing list