r284793 - Remove 24 instances of 'REQUIRES: shell'

Robinson, Paul via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 16:38:09 PDT 2016


> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf Of
> Reid Kleckner via cfe-commits
> Sent: Thursday, October 20, 2016 4:12 PM
> To: cfe-commits at lists.llvm.org
> Subject: r284793 - Remove 24 instances of 'REQUIRES: shell'
> 
> Author: rnk
> Date: Thu Oct 20 18:11:45 2016
> New Revision: 284793
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=284793&view=rev
> Log:
> Remove 24 instances of 'REQUIRES: shell'
> 
> Tests fall into one of the following categories:
> 
> - The requirement was unnecessary
> 
> - Additional quoting was required for backslashes in paths (see "sed -e
>   's/\\/\\\\/g'") in the sanitizer tests.
> 
> - OpenMP used 'REQUIRES: shell' as a proxy for the test failing on
>   Windows. Those tests fail there reliably, so use XFAIL instead.

Is there any expectation that they _should_ (eventually) work on Windows?
If not, seems like UNSUPPORTED would be clearer (and more efficient).
--paulr

> 
> I tried not to remove shell requirements that were added to suppress
> flaky test failures, but if I screwed up, we can add it back as needed.
> 
> Modified:
>     cfe/trunk/test/Analysis/plist-html-macros.c
>     cfe/trunk/test/CodeGen/address-safety-attr.cpp
>     cfe/trunk/test/CodeGen/asan-globals.cpp
>     cfe/trunk/test/CodeGen/sanitize-init-order.cpp
>     cfe/trunk/test/CodeGen/sanitize-thread-attr.cpp
>     cfe/trunk/test/CodeGen/ubsan-blacklist.c
>     cfe/trunk/test/Driver/fsanitize-blacklist.c
>     cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c
>     cfe/trunk/test/Modules/ModuleDebugInfo.cpp
>     cfe/trunk/test/Modules/ModuleDebugInfo.m
>     cfe/trunk/test/Modules/dependency-dump-dependent-module.m
>     cfe/trunk/test/Modules/empty.modulemap
>     cfe/trunk/test/Modules/explicit-build-extra-files.cpp
>     cfe/trunk/test/Modules/prune.m
>     cfe/trunk/test/Modules/signal.m
>     cfe/trunk/test/OpenMP/task_firstprivate_codegen.cpp
>     cfe/trunk/test/OpenMP/task_private_codegen.cpp
>     cfe/trunk/test/OpenMP/taskloop_firstprivate_codegen.cpp
>     cfe/trunk/test/OpenMP/taskloop_lastprivate_codegen.cpp
>     cfe/trunk/test/OpenMP/taskloop_private_codegen.cpp
>     cfe/trunk/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp
>     cfe/trunk/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp
>     cfe/trunk/test/OpenMP/taskloop_simd_private_codegen.cpp
>     cfe/trunk/test/PCH/debug-info-pch-path.c
> 
> Modified: cfe/trunk/test/Analysis/plist-html-macros.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plist-
> html-macros.c?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Analysis/plist-html-macros.c (original)
> +++ cfe/trunk/test/Analysis/plist-html-macros.c Thu Oct 20 18:11:45 2016
> @@ -1,12 +1,11 @@
> -// REQUIRES: shell
>  // RUN: %clang_cc1 -analyze -analyzer-checker=core -verify %s
>  // (sanity check)
> 
>  // RUN: rm -rf %t.dir
>  // RUN: mkdir -p %t.dir
>  // RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-
> output=plist-html -o %t.dir/index.plist %s
> -// RUN: ls %t.dir | grep \\.html | count 1
> -// RUN: grep \\.html %t.dir/index.plist | count 1
> +// RUN: ls %t.dir | grep '\.html' | count 1
> +// RUN: grep '\.html' %t.dir/index.plist | count 1
> 
>  // This tests two things: that the two calls to null_deref below are
> coalesced
>  // into a single bug by both the plist and HTML diagnostics, and that the
> plist
> 
> Modified: cfe/trunk/test/CodeGen/address-safety-attr.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/address-
> safety-attr.cpp?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/CodeGen/address-safety-attr.cpp (original)
> +++ cfe/trunk/test/CodeGen/address-safety-attr.cpp Thu Oct 20 18:11:45
> 2016
> @@ -9,12 +9,11 @@ int DefinedInDifferentFile(int *a);
>  // RUN: echo "fun:*BlacklistedFunction*" > %t.func.blacklist
>  // RUN: %clang_cc1 -std=c++11 -triple x86_64-apple-darwin -emit-llvm -o -
> %s -include %t.extra-source.cpp -fsanitize=address -fsanitize-
> blacklist=%t.func.blacklist | FileCheck -check-prefix=BLFUNC %s
> 
> -// RUN: echo "src:%s" > %t.file.blacklist
> +// The blacklist file uses regexps, so escape backslashes, which are
> common in
> +// Windows paths.
> +// RUN: echo "src:%s" | sed -e 's/\\/\\\\/g' > %t.file.blacklist
>  // RUN: %clang_cc1 -std=c++11 -triple x86_64-apple-darwin -emit-llvm -o -
> %s -include %t.extra-source.cpp -fsanitize=address -fsanitize-
> blacklist=%t.file.blacklist | FileCheck -check-prefix=BLFILE %s
> 
> -// FIXME: %t.file.blacklist is like
> "src:x:\path\to\clang\test\CodeGen\address-safety-attr.cpp"
> -// REQUIRES: shell
> -
>  // The sanitize_address attribute should be attached to functions
>  // when AddressSanitizer is enabled, unless no_sanitize_address attribute
>  // is present.
> 
> Modified: cfe/trunk/test/CodeGen/asan-globals.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/asan-
> globals.cpp?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/CodeGen/asan-globals.cpp (original)
> +++ cfe/trunk/test/CodeGen/asan-globals.cpp Thu Oct 20 18:11:45 2016
> @@ -1,9 +1,9 @@
>  // RUN: echo "int extra_global;" > %t.extra-source.cpp
>  // RUN: echo "global:*blacklisted_global*" > %t.blacklist
>  // RUN: %clang_cc1 -include %t.extra-source.cpp -fsanitize=address -
> fsanitize-blacklist=%t.blacklist -emit-llvm -o - %s | FileCheck %s
> -// RUN: echo "src:%s" > %t.blacklist-src
> +// The blacklist file uses regexps, so Windows path backslashes.
> +// RUN: echo "src:%s" | sed -e 's/\\/\\\\/g' > %t.blacklist-src
>  // RUN: %clang_cc1 -include %t.extra-source.cpp -fsanitize=address -
> fsanitize-blacklist=%t.blacklist-src -emit-llvm -o - %s | FileCheck %s --
> check-prefix=BLACKLIST-SRC
> -// REQUIRES: shell
> 
>  int global;
>  int dyn_init_global = global;
> 
> Modified: cfe/trunk/test/CodeGen/sanitize-init-order.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/sanitize-
> init-order.cpp?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/CodeGen/sanitize-init-order.cpp (original)
> +++ cfe/trunk/test/CodeGen/sanitize-init-order.cpp Thu Oct 20 18:11:45
> 2016
> @@ -1,12 +1,11 @@
>  // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - %s | FileCheck %s
> 
>  // Test blacklist functionality.
> -// RUN: echo "src:%s=init" > %t-file.blacklist
> +// RUN: echo "src:%s=init" | sed -e 's/\\/\\\\/g' > %t-file.blacklist
>  // RUN: echo "type:PODWithCtorAndDtor=init" > %t-type.blacklist
>  // RUN: echo "type:NS::PODWithCtor=init" >> %t-type.blacklist
>  // RUN: %clang_cc1 -fsanitize=address -fsanitize-blacklist=%t-
> file.blacklist -emit-llvm -o - %s | FileCheck %s --check-prefix=BLACKLIST
>  // RUN: %clang_cc1 -fsanitize=address -fsanitize-blacklist=%t-
> type.blacklist -emit-llvm -o - %s | FileCheck %s --check-prefix=BLACKLIST
> -// REQUIRES: shell
> 
>  struct PODStruct {
>    int x;
> 
> Modified: cfe/trunk/test/CodeGen/sanitize-thread-attr.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/sanitize-
> thread-attr.cpp?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/CodeGen/sanitize-thread-attr.cpp (original)
> +++ cfe/trunk/test/CodeGen/sanitize-thread-attr.cpp Thu Oct 20 18:11:45
> 2016
> @@ -1,10 +1,8 @@
>  // RUN: %clang_cc1 -triple x86_64-apple-darwin -emit-llvm -o - %s |
> FileCheck -check-prefix=WITHOUT %s
>  // RUN: %clang_cc1 -triple x86_64-apple-darwin -emit-llvm -o - %s -
> fsanitize=thread | FileCheck -check-prefix=TSAN %s
> -// RUN: echo "src:%s" > %t
> +// RUN: echo "src:%s" | sed -e 's/\\/\\\\/g' > %t
>  // RUN: %clang_cc1 -triple x86_64-apple-darwin -emit-llvm -o - %s -
> fsanitize=thread -fsanitize-blacklist=%t | FileCheck -check-prefix=BL %s
> 
> -// REQUIRES: shell
> -
>  // The sanitize_thread attribute should be attached to functions
>  // when ThreadSanitizer is enabled, unless no_sanitize_thread attribute
>  // is present.
> 
> Modified: cfe/trunk/test/CodeGen/ubsan-blacklist.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/ubsan-
> blacklist.c?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/CodeGen/ubsan-blacklist.c (original)
> +++ cfe/trunk/test/CodeGen/ubsan-blacklist.c Thu Oct 20 18:11:45 2016
> @@ -1,13 +1,10 @@
>  // Verify ubsan doesn't emit checks for blacklisted functions and files
>  // RUN: echo "fun:hash" > %t-func.blacklist
> -// RUN: echo "src:%s" > %t-file.blacklist
> +// RUN: echo "src:%s" | sed -e 's/\\/\\\\/g' > %t-file.blacklist
>  // RUN: %clang_cc1 -fsanitize=unsigned-integer-overflow -emit-llvm %s -o
> - | FileCheck %s --check-prefix=DEFAULT
>  // RUN: %clang_cc1 -fsanitize=unsigned-integer-overflow -fsanitize-
> blacklist=%t-func.blacklist -emit-llvm %s -o - | FileCheck %s --check-
> prefix=FUNC
>  // RUN: %clang_cc1 -fsanitize=unsigned-integer-overflow -fsanitize-
> blacklist=%t-file.blacklist -emit-llvm %s -o - | FileCheck %s --check-
> prefix=FILE
> 
> -// FIXME: %t-file.blacklist contains DOSish paths.
> -// REQUIRES: shell
> -
>  unsigned i;
> 
>  // DEFAULT: @hash
> 
> Modified: cfe/trunk/test/Driver/fsanitize-blacklist.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/fsanitize-
> blacklist.c?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Driver/fsanitize-blacklist.c (original)
> +++ cfe/trunk/test/Driver/fsanitize-blacklist.c Thu Oct 20 18:11:45 2016
> @@ -1,7 +1,7 @@
>  // General blacklist usage.
> 
>  // PR12920
> -// REQUIRES: clang-driver, shell
> +// REQUIRES: clang-driver
> 
>  // Make sure we don't match the -NOT lines with the linker invocation.
>  // Delimiters match the start of the cc1 and the start of the linker
> lines
> 
> Modified: cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/rewrite-
> map-in-diagnostics.c?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c (original)
> +++ cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c Thu Oct 20 18:11:45
> 2016
> @@ -9,6 +9,3 @@
>  // CHECK: note: diagnostic msg: {{.*}}rewrite.map
> 
>  // REQUIRES: crash-recovery
> -
> -// FIXME: This doesn't fail on "env clang". Investigating.
> -// REQUIRES: shell
> 
> Modified: cfe/trunk/test/Modules/ModuleDebugInfo.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/ModuleDebugInfo.cpp?rev=284793&r1=284792&r2
> =284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/ModuleDebugInfo.cpp (original)
> +++ cfe/trunk/test/Modules/ModuleDebugInfo.cpp Thu Oct 20 18:11:45 2016
> @@ -1,7 +1,7 @@
>  // Test that (the same) debug info is emitted for an Objective-C++
>  // module and a C++ precompiled header.
> 
> -// REQUIRES: asserts, shell
> +// REQUIRES: asserts
> 
>  // Modules:
>  // RUN: rm -rf %t
> 
> Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/ModuleDebugInfo.m?rev=284793&r1=284792&r2=2
> 84793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/ModuleDebugInfo.m (original)
> +++ cfe/trunk/test/Modules/ModuleDebugInfo.m Thu Oct 20 18:11:45 2016
> @@ -1,7 +1,7 @@
>  // Test that debug info is emitted for an Objective-C module and
>  // a precompiled header.
> 
> -// REQUIRES: asserts, shell
> +// REQUIRES: asserts
> 
>  // Modules:
>  // RUN: rm -rf %t
> 
> Modified: cfe/trunk/test/Modules/dependency-dump-dependent-module.m
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/dependency-dump-dependent-
> module.m?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/dependency-dump-dependent-module.m (original)
> +++ cfe/trunk/test/Modules/dependency-dump-dependent-module.m Thu Oct 20
> 18:11:45 2016
> @@ -14,9 +14,3 @@
>  // VFS: 'name': "Sub2.h"
> 
>  @import AlsoDependsOnModule;
> -
> -// FIXME: This fails on win32 due to ERROR_FILENAME_EXCED_RANGE
> -// if the working directory is too deep.
> -// We should make Win32/Path.inc capable of long pathnames with '\\?\'.
> -// For now, this is suppressed on win32.
> -// REQUIRES: shell
> 
> Modified: cfe/trunk/test/Modules/empty.modulemap
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/empty.modulemap?rev=284793&r1=284792&r2=284
> 793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/empty.modulemap (original)
> +++ cfe/trunk/test/Modules/empty.modulemap Thu Oct 20 18:11:45 2016
> @@ -14,7 +14,6 @@
>  // RUN: diff %t/base.pcm %t/check.pcm
>  //
>  // We expect an empty module to be less than 30KB (and at least 10K, for
> now).
> -// REQUIRES: shell
>  // RUN: wc -c %t/base.pcm | FileCheck --check-prefix=CHECK-SIZE %s
>  // CHECK-SIZE: {{(^|[^0-9])[12][0-9][0-9][0-9][0-9]($|[^0-9])}}
> 
> 
> Modified: cfe/trunk/test/Modules/explicit-build-extra-files.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/explicit-
> build-extra-files.cpp?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/explicit-build-extra-files.cpp (original)
> +++ cfe/trunk/test/Modules/explicit-build-extra-files.cpp Thu Oct 20
> 18:11:45 2016
> @@ -1,5 +1,3 @@
> -// REQUIRES: shell
> -//
>  // RUN: rm -rf %t
>  // RUN: mkdir %t
>  // RUN: cd %t
> 
> Modified: cfe/trunk/test/Modules/prune.m
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/prune.m?rev=284793&r1=284792&r2=284793&view
> =diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/prune.m (original)
> +++ cfe/trunk/test/Modules/prune.m Thu Oct 20 18:11:45 2016
> @@ -5,9 +5,6 @@
>  @import Module;
>  #endif
> 
> -// We need 'touch' and 'find' for this test to work.
> -// REQUIRES: shell
> -
>  // Clear out the module cache
>  // RUN: rm -rf %t
>  // Run Clang twice so we end up creating the timestamp file (the second
> time).
> @@ -28,7 +25,7 @@
>  // Set the DependsOnModule access time back more than four days.
>  // This shouldn't prune anything, because the timestamp has been updated,
> so
>  // the pruning mechanism won't fire.
> -// RUN: find %t -name DependsOnModule*.pcm | xargs touch -a -t
> 201101010000
> +// RUN: find %t -name DependsOnModule*.pcm | sed -e 's/\\/\//g' | xargs
> touch -a -t 201101010000
>  // RUN: %clang_cc1 -fmodules -fimplicit-module-maps -F %S/Inputs -
> fmodules-cache-path=%t -fmodules -fmodules-prune-interval=172800 -
> fmodules-prune-after=345600 %s -verify
>  // RUN: ls %t | grep modules.timestamp
>  // RUN: ls -R %t | grep ^Module.*pcm
> @@ -37,7 +34,7 @@
>  // Set both timestamp and DependsOnModule.pcm back beyond the cutoff.
>  // This should trigger pruning, which will remove DependsOnModule but not
> Module.
>  // RUN: touch -m -a -t 201101010000 %t/modules.timestamp
> -// RUN: find %t -name DependsOnModule*.pcm | xargs touch -a -t
> 201101010000
> +// RUN: find %t -name DependsOnModule*.pcm | sed -e 's/\\/\//g' | xargs
> touch -a -t 201101010000
>  // RUN: %clang_cc1 -fmodules -fimplicit-module-maps -F %S/Inputs -
> fmodules-cache-path=%t -fmodules -fmodules-prune-interval=172800 -
> fmodules-prune-after=345600 %s -verify
>  // RUN: ls %t | grep modules.timestamp
>  // RUN: ls -R %t | grep ^Module.*pcm
> 
> Modified: cfe/trunk/test/Modules/signal.m
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/signal.m?rev=284793&r1=284792&r2=284793&vie
> w=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/signal.m (original)
> +++ cfe/trunk/test/Modules/signal.m Thu Oct 20 18:11:45 2016
> @@ -1,4 +1,4 @@
> -// REQUIRES: crash-recovery,shell
> +// REQUIRES: crash-recovery
>  // RUN: rm -rf %t
> 
>  // Crash building module.
> 
> Modified: cfe/trunk/test/OpenMP/task_firstprivate_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/task_firstprivate_codegen.cpp?rev=284793&r1=
> 284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/task_firstprivate_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/task_firstprivate_codegen.cpp Thu Oct 20
> 18:11:45 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32.
> -// REQUIRES: shell
> +// XFAIL: win32
>  #ifndef ARRAY
>  #ifndef HEADER
>  #define HEADER
> 
> Modified: cfe/trunk/test/OpenMP/task_private_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/task_private_codegen.cpp?rev=284793&r1=28479
> 2&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/task_private_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/task_private_codegen.cpp Thu Oct 20 18:11:45
> 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32. Investigating.
> -// REQUIRES: shell
> +// XFAIL: win32
> 
>  #ifndef ARRAY
>  #ifndef HEADER
> 
> Modified: cfe/trunk/test/OpenMP/taskloop_firstprivate_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/taskloop_firstprivate_codegen.cpp?rev=284793
> &r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/taskloop_firstprivate_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/taskloop_firstprivate_codegen.cpp Thu Oct 20
> 18:11:45 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32.
> -// REQUIRES: shell
> +// XFAIL: win32
>  #ifndef ARRAY
>  #ifndef HEADER
>  #define HEADER
> 
> Modified: cfe/trunk/test/OpenMP/taskloop_lastprivate_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/taskloop_lastprivate_codegen.cpp?rev=284793&
> r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/taskloop_lastprivate_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/taskloop_lastprivate_codegen.cpp Thu Oct 20
> 18:11:45 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32.
> -// REQUIRES: shell
> +// XFAIL: win32
>  #ifndef ARRAY
>  #ifndef HEADER
>  #define HEADER
> 
> Modified: cfe/trunk/test/OpenMP/taskloop_private_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/taskloop_private_codegen.cpp?rev=284793&r1=2
> 84792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/taskloop_private_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/taskloop_private_codegen.cpp Thu Oct 20 18:11:45
> 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32. Investigating.
> -// REQUIRES: shell
> +// XFAIL: win32
> 
>  #ifndef ARRAY
>  #ifndef HEADER
> 
> Modified: cfe/trunk/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp?rev=2
> 84793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp
> (original)
> +++ cfe/trunk/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp Thu Oct
> 20 18:11:45 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32.
> -// REQUIRES: shell
> +// XFAIL: win32
>  #ifndef ARRAY
>  #ifndef HEADER
>  #define HEADER
> 
> Modified: cfe/trunk/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp?rev=28
> 4793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp Thu Oct 20
> 18:11:45 2016
> @@ -6,8 +6,8 @@
>  // RUN: %clang_cc1 -verify -fopenmp -x c++ -std=c++11 -DARRAY -triple
> x86_64-apple-darwin10 -emit-llvm %s -o - | FileCheck -check-prefix=ARRAY
> %s
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
> -// It doesn't pass on win32.
> -// REQUIRES: shell
> +// XFAIL: win32
> +
>  #ifndef ARRAY
>  #ifndef HEADER
>  #define HEADER
> 
> Modified: cfe/trunk/test/OpenMP/taskloop_simd_private_codegen.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/OpenMP/taskloop_simd_private_codegen.cpp?rev=284793
> &r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/OpenMP/taskloop_simd_private_codegen.cpp (original)
> +++ cfe/trunk/test/OpenMP/taskloop_simd_private_codegen.cpp Thu Oct 20
> 18:11:45 2016
> @@ -7,7 +7,7 @@
>  // expected-no-diagnostics
>  // REQUIRES: x86-registered-target
>  // It doesn't pass on win32. Investigating.
> -// REQUIRES: shell
> +// XFAIL: win32
> 
>  #ifndef ARRAY
>  #ifndef HEADER
> 
> Modified: cfe/trunk/test/PCH/debug-info-pch-path.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/PCH/debug-info-
> pch-path.c?rev=284793&r1=284792&r2=284793&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/PCH/debug-info-pch-path.c (original)
> +++ cfe/trunk/test/PCH/debug-info-pch-path.c Thu Oct 20 18:11:45 2016
> @@ -1,5 +1,3 @@
> -// REQUIRES: shell
> -//
>  // RUN: rm -rf %t
>  // RUN: mkdir %t
>  // RUN: cd %t
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list