r284749 - [clang-cl] Fix test that shouldn't be running on non-x86

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 10:41:09 PDT 2016


Author: rengolin
Date: Thu Oct 20 12:41:08 2016
New Revision: 284749

URL: http://llvm.org/viewvc/llvm-project?rev=284749&view=rev
Log:
[clang-cl] Fix test that shouldn't be running on non-x86

The clang-cl test required x86-registered-target but it defaulted to the
host's triple and AArch64 still doesn't support COFF, so the test failed.

The triple was "aarch64-pc-windows-msvc18.0.0" with ObjectFormat equals
llvm::Triple::COFF, failing assertion:

Assertion `(TT.isOSBinFormatELF() || TT.isOSBinFormatMachO()) &&
          "Only expect Darwin and ELF targets"

in AArch64MCTargetDesc.cpp:78.

Making the test only run on Windows hosts obviously fixes the problem.

Modified:
    cfe/trunk/test/Driver/cl-pch.c

Modified: cfe/trunk/test/Driver/cl-pch.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-pch.c?rev=284749&r1=284748&r2=284749&view=diff
==============================================================================
--- cfe/trunk/test/Driver/cl-pch.c (original)
+++ cfe/trunk/test/Driver/cl-pch.c Thu Oct 20 12:41:08 2016
@@ -1,4 +1,4 @@
-// REQUIRES: x86-registered-target
+// REQUIRES: system-windows
 //
 // RUN: rm -rf %t
 // RUN: mkdir %t




More information about the cfe-commits mailing list