[PATCH] D25769: [clang-tidy] Simplify modernize-use-default

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 06:35:32 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a small nit, but you may want to wait for @djasper to weigh in on the removed comment question.



================
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:266
       // If there are constructor initializers, they must be removed.
-      if (Ctor->getNumCtorInitializers() != 0) {
-        StartLoc = getColonLoc(Result.Context, Ctor);
-        if (!StartLoc.isValid())
-          return;
+      for (const CXXCtorInitializer *Init : Ctor->inits()) {
+        RemoveInitializers.emplace_back(
----------------
You can use `const auto *` here.


https://reviews.llvm.org/D25769





More information about the cfe-commits mailing list